Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scripts to test the library #16

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Update scripts to test the library #16

merged 1 commit into from
Jul 13, 2023

Conversation

buddly27
Copy link
Contributor

@buddly27 buddly27 commented Jul 11, 2023

Use Python script instead of raw CMake to compile USD within the test to be consistent with Pixar's process.

@buddly27 buddly27 self-assigned this Jul 11, 2023
@buddly27 buddly27 changed the title Update scripts to test the library on Linux and MacOS Update scripts to test the library Jul 11, 2023
@buddly27 buddly27 changed the base branch from main to dev July 11, 2023 22:15
.github/workflows/test.yml Outdated Show resolved Hide resolved
@davvid
Copy link
Member

davvid commented Jul 11, 2023

Looks good to me. Feel free to merge anytime!

- Use Python build script instead of CMake to compile USD
  and install GTest via apt-get instead of Conan to simplify the
  process and make it more consistent with Pixar's process.
- Reduce minimum version required from TBB to 2017 as this is the one
  installed via the USD build script for v20.11.
- Add step to check if formatting is correct.
- Fix minor warning due to missing "override" keywords.
- Update clang-format config to conform with older version.
- Add release note.
@buddly27 buddly27 merged commit 9bd22b0 into dev Jul 13, 2023
2 checks passed
@buddly27 buddly27 deleted the update-github-tests branch July 13, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants