Remove conflicting static method from Metadata.Custom interface (open…

…search-project#13869) Signed-off-by: Shivansh Arora <hishiv@amazon.com>
wdongyu · Aug 22, 2024 · 4154740 · 4154740
1 parent 85b0e36
commit 4154740
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/server/src/main/java/org/opensearch/cluster/metadata/Metadata.java b/server/src/main/java/org/opensearch/cluster/metadata/Metadata.java
@@ -180,11 +180,6 @@ static Custom fromXContent(XContentParser parser, String name) throws IOExceptio
             // handling any Exception is caller's responsibility
             return parser.namedObject(Custom.class, name, null);
         }
-
-        static Custom fromXContent(XContentParser parser) throws IOException {
-            String currentFieldName = parser.currentName();
-            return fromXContent(parser, currentFieldName);
-        }
     }
 
     public static final Setting<Integer> DEFAULT_REPLICA_COUNT_SETTING = Setting.intSetting(

diff --git a/server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java b/server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
@@ -147,7 +147,7 @@ public class RemoteClusterStateService implements Closeable {
     public static final ChecksumBlobStoreFormat<Metadata.Custom> CUSTOM_METADATA_FORMAT = new ChecksumBlobStoreFormat<>(
         "custom",
         METADATA_NAME_FORMAT,
-        Metadata.Custom::fromXContent
+        null // no need of reader here, as this object is only used to write/serialize the object
     );
 
     /**