Collect telemetry #258
Merged
Collect telemetry #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacodg
reviewed
Aug 8, 2024
|
Can you add info to the README about Ladybug being able to receive OpenTelemetry data? And maybe an example of how to send information to Ladybug using the new API endpoint? |
jacodg
requested changes
Aug 14, 2024
| @@ -91,6 +91,7 @@ public void setObserverRoles(List<String> observerRoles) { | |||
| addConfigurationPart("PUT/" + ApiServlet.LADYBUG_API_PATH + "/testtool/node-link-strategy$", observerRoles); | |||
| addConfigurationPart("GET/" + ApiServlet.LADYBUG_API_PATH + "/metadata/.*$", observerRoles); | |||
| addConfigurationPart("GET/" + ApiServlet.LADYBUG_API_PATH + "/report/.*$", observerRoles); | |||
| addConfigurationPart("POST/" + ApiServlet.LADYBUG_API_PATH + "/collector/.*$", observerRoles); | |||
There was a problem hiding this comment.
I think we need to create a separate role. Can you remove this line and add the following below the setTesterRoles() method?
public void setWebServiceRoles(List<String> webServiceRoles) {
if (constructorDone) log.info("Set web service roles");
addConfigurationPart("POST/" + ApiServlet.LADYBUG_API_PATH + "/collector/.*$", webServiceRoles);
}
And add setWebServiceRoles(null); below setTesterRoles(null);?
jacodg
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created an API to gather telemetry data from OpenTelemetry (https://opentelemetry.io/). When code is instrumented with the OpenTelemetry library, it is possible to use the endpoint from this API to gather it in Ladybug.