add separate fit and test functions #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is useful if you want to train a model and then evaluate on a bunch of different test sets |
abarrainkua
approved these changes
Dec 22, 2021
abarrainkua
approved these changes
Dec 22, 2021
|
As we discussed before, the whole async stuff should be ripped out anyway and replaced by something based on Apart from that, this seems fine. |
tmke8
approved these changes
Dec 22, 2021
| self.__is_fairness_algo = is_fairness_algo | ||
|
|
||
| @abstractmethod | ||
| def fit(self, train: DataTuple) -> InAlgorithm: |
There was a problem hiding this comment.
This would be the perfect opportunity to use -> Self but it's not widely supported yet: python/typeshed#6300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added separate fit and predict methods for the InProcessing models.
This is mostly just splitting up what's already packaged together in various
train_and_predictfunctions.The bit that needs double checking is for the async algos. Here a model save location now gets passed, then the trained model is just dumped there. I'm not sure if there's a better way to do this or not. I imagine that there is.
There's now quite a lot of duplication. This should really be sorted....