Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky test TestRunReturnsError #120

Closed
bboreham opened this issue Aug 23, 2018 · 0 comments
Closed

flaky test TestRunReturnsError #120

bboreham opened this issue Aug 23, 2018 · 0 comments
Labels
bug

Comments

@bboreham
Copy link
Collaborator

As seen in https://circleci.com/gh/weaveworks/common/412, https://circleci.com/gh/weaveworks/common/406

panic: test timed out after 1m0s

goroutine 12 [running]:
testing.(*M).startAlarm.func1()
	/usr/local/go/src/testing/testing.go:1240 +0x146
created by time.goFunc
	/usr/local/go/src/time/sleep.go:172 +0x52

goroutine 1 [chan receive]:
testing.(*T).Run(0xc4202be000, 0xc8d45a, 0x13, 0xcaa220, 0xc4201c9c01)
	/usr/local/go/src/testing/testing.go:825 +0x597
testing.runTests.func1(0xc4202be000)
	/usr/local/go/src/testing/testing.go:1063 +0xa5
testing.tRunner(0xc4202be000, 0xc4201c9d48)
	/usr/local/go/src/testing/testing.go:777 +0x16e
testing.runTests(0xc42024e2a0, 0x1040a60, 0x3, 0x3, 0xc42026e080)
	/usr/local/go/src/testing/testing.go:1061 +0x4e2
testing.(*M).Run(0xc42026e080, 0x0)
	/usr/local/go/src/testing/testing.go:978 +0x2ce
main.main()
	_testmain.go:184 +0x335

goroutine 50 [syscall]:
os/signal.signal_recv(0x487db1)
	/usr/local/go/src/runtime/sigqueue.go:139 +0xa6
os/signal.loop()
	/usr/local/go/src/os/signal/signal_unix.go:22 +0x30
created by os/signal.init.0
	/usr/local/go/src/os/signal/signal_unix.go:28 +0x4f

goroutine 6 [select, locked to thread]:
runtime.gopark(0xcabfa8, 0x0, 0xc85824, 0x6, 0x18, 0x1)
	/usr/local/go/src/runtime/proc.go:291 +0xf9
runtime.selectgo(0xc420097f50, 0xc4200262a0)
	/usr/local/go/src/runtime/select.go:392 +0x11d4
runtime.ensureSigM.func1()
	/usr/local/go/src/runtime/signal_unix.go:549 +0x19f
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:2361 +0x1

goroutine 41 [chan receive]:
github.com/weaveworks/common/server.TestRunReturnsError.func1(0xc4202c01e0)
	/go/src/github.com/weaveworks/common/server/server_test.go:116 +0x218
testing.tRunner(0xc4202c01e0, 0xc42025cb60)
	/usr/local/go/src/testing/testing.go:777 +0x16e
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:824 +0x565

goroutine 54 [select]:
github.com/weaveworks/common/signals.(*Handler).Loop(0xc4201b43f0)
	/go/src/github.com/weaveworks/common/signals/signals.go:47 +0x284
github.com/weaveworks/common/server.(*Server).Run.func1(0xc4202c6000, 0xc42028c3c0)
	/go/src/github.com/weaveworks/common/server/server.go:187 +0x71
created by github.com/weaveworks/common/server.(*Server).Run
	/go/src/github.com/weaveworks/common/server/server.go:186 +0x91

goroutine 62 [select]:
github.com/weaveworks/common/signals.(*Handler).Loop(0xc420472c00)
	/go/src/github.com/weaveworks/common/signals/signals.go:47 +0x284
github.com/weaveworks/common/server.(*Server).Run.func1(0xc420272a00, 0xc4201da960)
	/go/src/github.com/weaveworks/common/server/server.go:187 +0x71
created by github.com/weaveworks/common/server.(*Server).Run
	/go/src/github.com/weaveworks/common/server/server.go:186 +0x91

goroutine 40 [chan receive]:
testing.(*T).Run(0xc4202c00f0, 0xc83cb0, 0x4, 0xc42025cb60, 0x0)
	/usr/local/go/src/testing/testing.go:825 +0x597
github.com/weaveworks/common/server.TestRunReturnsError(0xc4202c00f0)
	/go/src/github.com/weaveworks/common/server/server_test.go:105 +0x11e
testing.tRunner(0xc4202c00f0, 0xcaa220)
	/usr/local/go/src/testing/testing.go:777 +0x16e
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:824 +0x565

goroutine 43 [chan receive]:
github.com/weaveworks/common/server.(*Server).Run(0xc420272a00, 0xc420084fb8, 0x45c96d)
	/go/src/github.com/weaveworks/common/server/server.go:222 +0x1d1
github.com/weaveworks/common/server.TestRunReturnsError.func1.1(0xc4202415c0, 0xc420272a00)
	/go/src/github.com/weaveworks/common/server/server_test.go:112 +0x39
created by github.com/weaveworks/common/server.TestRunReturnsError.func1
	/go/src/github.com/weaveworks/common/server/server_test.go:111 +0x175

goroutine 27 [IO wait]:
internal/poll.runtime_pollWait(0x7fa45dd95ea0, 0x72, 0xc4202d5be0)
	/usr/local/go/src/runtime/netpoll.go:173 +0x5e
internal/poll.(*pollDesc).wait(0xc42026e518, 0x72, 0xc4201d8400, 0x0, 0x0)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:85 +0xe5
internal/poll.(*pollDesc).waitRead(0xc42026e518, 0xffffffffffffff00, 0x0, 0x0)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:90 +0x4b
internal/poll.(*FD).Accept(0xc42026e500, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
	/usr/local/go/src/internal/poll/fd_unix.go:372 +0x2e2
net.(*netFD).accept(0xc42026e500, 0xc4202802a8, 0xc420084d90, 0xc420226d80)
	/usr/local/go/src/net/fd_unix.go:238 +0x53
net.(*TCPListener).accept(0xc4202501f8, 0xc4201d8470, 0xc420084df0, 0x4538bd)
	/usr/local/go/src/net/tcpsock_posix.go:136 +0x4e
net.(*TCPListener).Accept(0xc4202501f8, 0xcab348, 0xc4202801c0, 0xc420232f60, 0x0)
	/usr/local/go/src/net/tcpsock.go:259 +0x50
github.com/weaveworks/common/vendor/google.golang.org/grpc.(*Server).Serve(0xc4202801c0, 0xd0d5a0, 0xc4202501f8, 0x0, 0x0)
	/go/src/github.com/weaveworks/common/vendor/google.golang.org/grpc/server.go:544 +0x2e1
github.com/weaveworks/common/server.(*Server).Run.func3(0xc420272a00, 0xc4201da960)
	/go/src/github.com/weaveworks/common/server/server.go:211 +0x9e
created by github.com/weaveworks/common/server.(*Server).Run
	/go/src/github.com/weaveworks/common/server/server.go:210 +0x199
FAIL	github.com/weaveworks/common/server	60.044s
@bboreham bboreham added the bug label Aug 23, 2018
@bboreham bboreham mentioned this issue Aug 23, 2018
Merged
@tomwilkie tomwilkie mentioned this issue Aug 24, 2018
Merged
tomwilkie added a commit to tomwilkie/weaveworks-common that referenced this issue Aug 24, 2018
@tomwilkie
Fix weaveworks#120: buffer the errChan, as one of the servers could r…
3949abc 
…eturn an error before Run starts listening on errChan.

Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
bboreham added a commit that referenced this issue May 15, 2019
@bboreham
Squashed 'tools/' changes from 41c5622..d6cc704
57a64ff 
d6cc704 Fix comment
7139116 Revert "Push comments to the left so they don't appear in scripts"
e47e58f Push comments to the left so they don't appear in scripts
3945fce Remove nonexistent env var GIT_TAG
cd62992 Merge pull request #156 from weaveworks/drop-quay
af0eb51 Merge pull request #157 from weaveworks/fix-image-tag-prefix-length
0b9aee4 Fix image-tag object name prefix length to 8 chars.
813c28f Move from CircleCI 1.0 to 2.0
425cf4e Move from quay.io to Dockerhub
87ccf4f Merge pull request #155 from weaveworks/go-1-12
c31bc28 Update lint script to work with Go 1.12
ed8e380 Update to Go 1.12.1
ec369f5 Merge pull request #153 from dholbach/drop-email
ef7418d weave-users mailing list is closed: https://groups.google.com/a/weave.works/forum/#!topic/weave-users/0QXWGOPdBfY
6954a57 Merge pull request #144 from weaveworks/golang-1.11.1
9649eed Upgrade build image from golang:1.10.0-strech to 1.11.1-strech
59263a7 Merge pull request #141 from weaveworks/update-context
e235c9b Merge pull request #143 from weaveworks/gc-wks-test-vms
c865b4c scheduler: please lint/flake8
da61568 scheduler: please lint/yapf
ce9d78e scheduler: do not cache discovery doc
e4b7873 scheduler: add comment about GCP projects' IAM roles needed to list/delete instances and firewall rules
ff7ec8e scheduler: add comment about CircleCI projects' access via the API
2477d98 scheduler: deploy command now sets the current datetime as the version
5fcd880 scheduler: pass CircleCI API token in for private projects
6b8c323 scheduler: more details in case of failure to get running builds from CircleCI
0871aff scheduler: downgrade google-api-python-client from 1.7.4 to 1.6.7
b631e7f scheduler: add GC of WKS test VMs and firewall rules
a923a32 scheduler: document setup and deployment
013f508 scheduler: lock dependencies' versions
6965a4a Merge pull request #142 from weaveworks/fix-build
23298c6 Fix golint expects import golang.org/x/lint/golint
482f4cd Context is now part of the Go standard library
2bbc9a0 Merge pull request #140 from weaveworks/sched-http-retry
c3726de Add retries to sched util http calls
2cc7b5a Merge pull request #139 from meghalidhoble/master
fd9b0a7 Change : Modified the lint tools to skip the shfmt check if not installed. Why the change : For ppc64le the specific version of shfmt is not available, hence skipped completely the installation of shfmt tool. Thus this change made.
bc645c7 Merge pull request #138 from dholbach/add-license-file
a642e02 license: add Apache 2.0 license text
9bf5956 Merge pull request #109 from hallum/master
d971d82 Merge pull request #134 from weaveworks/2018-07-03-gcloud-regepx
32e7aa2 Merge pull request #137 from weaveworks/gcp-fw-allow-kube-apiserver
bbb6735 Allow CI to access k8s API server on GCP instances
764d46c Merge pull request #135 from weaveworks/2018-07-04-docker-ansible-playbook
ecc2a4e Merge pull request #136 from weaveworks/2018-07-05-gcp-private-ips
209b7fb tools: Add private_ips to the terraform output
369a655 tools: Add an ansible playbook that just installs docker
a643e27 tools: Use --filter instead of --regexp with gcloud
b8eca88 Merge pull request #128 from weaveworks/actually-say-whats-wrong
379ce2b Merge pull request #133 from weaveworks/fix-decrypt
3b906b5 Fix incompatibility with recent versions of OpenSSL
f091ab4 Merge pull request #132 from weaveworks/add-opencontainers-labels-to-dockerfiles
248def1 Inject git revision in Dockerfiles
64f2c28 Add org.opencontainers.image.* labels to Dockerfiles
ea96d8e add information about how to get help (#129)
f066ccd Make yapf diff failure look like an error
34d81d7 Merge pull request #127 from weaveworks/golang-1.10.0-stretch
89a0b4f Use golang:1.10.0-stretch image.
ca69607 Merge pull request #126 from weaveworks/disable-apt-daily-test
f5dc5d5 Create "setup-apt" role
7fab441 Rename bazel to bazel-rules (#125)
ccc8316 Revert "Gocyclo should return error code if issues detected" (#124)
1fe184f Bazel rules for building gogo protobufs (#123)
b917bb8 Merge pull request #122 from weaveworks/fix-scope-gc
c029ce0 Add regex to match scope VMs
0d4824b Merge pull request #121 from weaveworks/provisioning-readme-terraform
5a82d64 Move terraform instructions to tf section
d285d78 Merge pull request #120 from weaveworks/gocyclo-return-value
76b94a4 Do not spawn subshell when reading cyclo output
93b3c0d Use golang:1.9.2-stretch image
d40728f Gocyclo should return error code if issues detected
c4ac1c3 Merge pull request #114 from weaveworks/tune-spell-check
8980656 Only check files
12ebc73 Don't spell-check pki files
578904a Special-case spell-check the same way we do code checks
e772ed5 Special-case on mime type and extension using just patterns
ae82b50 Merge pull request #117 from weaveworks/test-verbose
8943473 Propagate verbose flag to 'go test'.
7c79b43 Merge pull request #113 from weaveworks/update-shfmt-instructions
258ef01 Merge pull request #115 from weaveworks/extra-linting
e690202 Use tools in built image to lint itself
126eb56 Add shellcheck to bring linting in line with scope
63ad68f Don't run lint on files under .git
51d908a Update shfmt instructions
e91cb0d Merge pull request #112 from weaveworks/add-python-lint-tools
0c87554 Add yapf and flake8 to golang build image
35679ee Merge pull request #110 from weaveworks/parallel-push-errors
3ae41b6 Remove unneeded if block
51ff31a Exit on first error
0faad9f Check for errors when pushing images in parallel
d87cd02 Add arg flag override for destination socks host:port in pacfile.
74dc626 Merge pull request #108 from weaveworks/disable-apt-daily
b4f1d91 Merge pull request #107 from weaveworks/docker-17-update
7436aa1 Override apt daily job to not run immediately on boot
7980f15 Merge pull request #106 from weaveworks/document-docker-install-role
f741e53 Bump to Docker 17.06 from CE repo
61796a1 Update Docker CE Debian repo details
0d86f5e Allow for Docker package to be named docker-ce
065c68d Document selection of Docker installation role.
3809053 Just --porcelain; it defaults to v1
11400ea Merge pull request #105 from weaveworks/remove-weaveplugin-remnants
b8b4d64 remove weaveplugin remnants
35099c9 Merge pull request #104 from weaveworks/pull-docker-py
cdd48fc Pull docker-py to speed tests/builds up.
e1c6c24 Merge pull request #103 from weaveworks/test-build-tags
d5d71e0 Add -tags option so callers can pass in build tags
8949b2b Merge pull request #98 from weaveworks/git-status-tag
ac30687 Merge pull request #100 from weaveworks/python_linting
4b125b5 Pin yapf & flake8 versions
7efb485 Lint python linting function
444755b Swap diff direction to reflect changes required
c5b2434 Install flake8 & yapf
5600eac Lint python in build-tools repo
0b02ca9 Add python linting
c011c0d Merge pull request #79 from kinvolk/schu/python-shebang
6577d07 Merge pull request #99 from weaveworks/shfmt-version
00ce0dc Use git status instead of diff to add 'WIP' tag
411fd13 Use shfmt v1.3.0 instead of latest from master.
0d6d4da Run shfmt 1.3 on the code.
5cdba32 Add sudo
c322ca8 circle.yml: Install shfmt binary.
e59c225 Install shfmt 1.3 binary.
30706e6 Install pyhcl in the build container.
960d222 Merge pull request #97 from kinvolk/alban/update-shfmt-3
1d535c7 shellcheck: fix escaping issue
5542498 Merge pull request #96 from kinvolk/alban/update-shfmt-2
32f7cc5 shfmt: fix coding style
09f72af lint: print the diff in case of error
571c7d7 Merge pull request #95 from kinvolk/alban/update-shfmt
bead6ed Update for latest shfmt
b08dc4d Update for latest shfmt (#94)
2ed8aaa Add no-race argument to test script (#92)
80dd78e Merge pull request #91 from weaveworks/upgrade-go-1.8.1
08dcd0d Please ./lint as shfmt changed its rules between 1.0.0 and 1.3.0.
a8bc9ab Upgrade default Go version to 1.8.1.
31d069d Change Python shebang to `#!/usr/bin/env python`

git-subtree-dir: tools
git-subtree-split: d6cc704a2892e8d85aa8fa4d201c1a404f02dfa4
yeya24 pushed a commit to yeya24/common that referenced this issue Jun 12, 2024
@simonpasquier @brian-brazil
route: support for instrumentation (weaveworks#120)
e4aa40a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bboreham