Allow the AWS backend to get credentials from its environment. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
|
What is the failure mode now if you forget to supply credentials via parameter or environment? |
|
Assuming there are no credentials in the environment it'll still fail on startup, with something along the lines of "No credentials in chain". If you run it on AWS through, there are always some credentials available - they just might not allow you to read or write from dynamodb. In this case the individual reads & writes will fail. |
|
ping @bboreham? |
|
I was trying to get more feedback from users of this library. |
|
Thanks @tomwilkie ! |
This was referenced Aug 7, 2018
yeya24
pushed a commit
to yeya24/common
that referenced
this pull request
Jun 12, 2024
`0y` looks very, very weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See cortexproject/cortex#898
Signed-off-by: Tom Wilkie tom.wilkie@gmail.com