Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerate multiple hooks' initialisations #155

Closed
wants to merge 1 commit into from
Closed

Tolerate multiple hooks' initialisations #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ func New(cfg Config) (*Server, error) {
Help: "Time (in seconds) spent serving HTTP requests.",
Buckets: instrument.DefBuckets,
}, []string{"method", "route", "status_code", "ws"})
// Try to unregister the requestDuration, in case already registered for some reason,
// e.g. double initialisation/configuration done by mistake by the end-user.
prometheus.Unregister(requestDuration)
prometheus.MustRegister(requestDuration)

// If user doesn't supply a logging implementation, by default instantiate
Expand Down