HTTP 500s sent via gRPC are now sent as gRPC errors, with the body as a tailer.

[tomwilkie]

Also, don't need to connect on a background goroutine any more, this is fixed in grpc/grpc-go#976.

Fixes #35

[bboreham]

There's a note in circle.yml saying not to change it until this PR is "fixed"; can anyone shed light on what that would mean, and if it has happened?

[jml]

No, I don't know, and regret not insisting on more context when I reviewed this.

At a guess, it's related to the CircleCI failure we can see in the commit log:

httpgrpc/httpgrpc.go:22:2: cannot find package "google.golang.org/genproto/googleapis/rpc/status" in any of:

	/go/src/github.com/weaveworks/common/vendor/google.golang.org/genproto/googleapis/rpc/status (vendor tree)

	/usr/local/go/src/google.golang.org/genproto/googleapis/rpc/status (from $GOROOT)

	/go/src/google.golang.org/genproto/googleapis/rpc/status (from $GOPATH)

httpgrpc/httpgrpc.go:24:2: cannot find package "google.golang.org/grpc/status" in any of:

	/go/src/github.com/weaveworks/common/vendor/google.golang.org/grpc/status (vendor tree)

	/usr/local/go/src/google.golang.org/grpc/status (from $GOROOT)

	/go/src/google.golang.org/grpc/status (from $GOPATH)

I would suggest removing the workaround (i.e. installing dep in the normal way, whatever that is), and seeing what happens.