Support HTTP-style error codes from GRPC errors #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 30, 2017 13:19
One thing must be broken out to prevent circular imports, this seemed nicer.
tomwilkie
reviewed
May 30, 2017
| s, ok := status.FromError(err) | ||
| if !ok { | ||
| fmt.Println("not status") |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
tomwilkie
reviewed
May 30, 2017
middleware/grpc_instrumentation.go
Outdated
| status = "error" | ||
| errInfo, ok := status.FromError(err) | ||
| if ok { | ||
| respStatus = strconv.Itoa(int(errInfo.Code())) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
tomwilkie
reviewed
May 30, 2017
middleware/grpc_instrumentation.go
Outdated
| } | ||
|
|
||
| // ErrorToStatus handler to convert error objects to http-response errors | ||
| type ErrorToStatus func(error) (code int32, message string, err error) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
LGTM with a few minor nits. |
|
Also, can we have a helper function in line with http.Error? https://golang.org/pkg/net/http/#Error |
|
Even better, an |
This was referenced May 16, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new grpc middleware factory for converting errors into http-style error objects, and updates the existing grpc prometheus middleware to understand that.
There's a new test covering the GRPC server to test this error handling.
I split out the httpgrpc server code to fix a circular import.