Grafana Zabbix plugin support added #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jml
changed the title
jml
reviewed
Apr 3, 2017
grafanalib/zabbix.py
Outdated
| if not re.match("^[+-]?\d*[smhdMY]$", value): | ||
| raise ValueError( | ||
| "valid interval should be a string " | ||
| "matching an expressiong: ^[+-]?\d*[smhdMY]$. " |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
grafanalib/zabbix.py
Outdated
| raise ValueError( | ||
| "valid interval should be a string " | ||
| "matching an expressiong: ^[+-]?\d*[smhdMY]$. " | ||
| "Exaxples: 24h 7d 1M +24h -24h") |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
grafanalib/zabbix.py
Outdated
| """ | ||
| if isinstance(value, int) or isinstance(value, float): | ||
| return | ||
| raise ValueError("{attr} should be interger or float".format( |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
grafanalib/zabbix.py
Outdated
| A validator that raises a :exc:`ValueError` if the attribute value is not | ||
| a number (not int or float). | ||
| """ | ||
| if isinstance(value, int) or isinstance(value, float): |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
grafanalib/zabbix.py
Outdated
|
|
||
| __options = ("avg", "min", "max", "median") | ||
| __default_interval = "1m" | ||
| __default_function = "avg" |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
grafanalib/zabbix.py
Outdated
| http://docs.grafana-zabbix.org/reference/functions/#scale | ||
| """ | ||
|
|
||
| __default_factor = 100 |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Fixed according to @jml comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grafana Zabbix pluging support added.
Plugin docs: http://docs.grafana-zabbix.org/