Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Table panel support #81

Closed
wants to merge 2 commits into from
Closed

Add Table panel support #81

wants to merge 2 commits into from

Conversation

mikebryant
Copy link
Contributor

No description provided.

jml
jml suggested changes Oct 16, 2017
View reviewed changes
Copy link
Contributor

@jml jml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I can definitely see how this would be useful, but I've got a couple of questions.

grafanalib/core.py
class Column(object):
"""Details of an aggregation column in a table panel

:param style: shorthand for specifying a style that maps to this column

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

grafanalib/core.py
'decimals': self.decimals,
'thresholds': self.thresholds,
'unit': self.unit,
})

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

grafanalib/core.py
if style.pattern and style.pattern != column.text:
raise ValueError("Column style pattern must match the column name if specified")
style.pattern = column.text
styles.append(style)

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@jml
Copy link
Contributor

jml commented Oct 19, 2017

Thanks for getting back to me @mikebryant. Sorry for the delay in replying.

I'm going to be away until Oct 30, so probably won't have a chance to give this the review it deserves until then.

@jml jml self-requested a review November 10, 2017 16:22
@jml
Copy link
Contributor

jml commented Nov 13, 2017

I haven't abandoned this. I'm mucking around with it when I get the chance to get my own thinking clear.

@jml jml mentioned this pull request Nov 21, 2017
Closed
@jml jml mentioned this pull request Jan 5, 2018
Merged
@jml
Copy link
Contributor

jml commented Jan 5, 2018

Superseded by #104

@jml jml closed this Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jml jml Awaiting requested review from jml

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikebryant @jml