This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
FileWatcher: Support internal moves without re-creating and multiple active moves at once #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twelho
added
kind/design
|
Approved by @luxas and CI is green, merging 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the
FileWatcherto perform internal moves (e.g. a watched directory to its watched subdirectory) by performing a remap of theMappedRawStorageinstead of having to delete and re-create the VM. Also enables tracking multiple active moves at once, somv *.yml subdir/now works, and creation and deletion updates for files moved in/out of watched directories now work properly.Fixes #327.
cc @luxas