This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Split packages so we can extract gitops-toolkit
#347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luxas
changed the title
luxas
added
the
kind/enhancement
luxas
changed the title
gitops-toolkit
twelho
approved these changes
Aug 19, 2019
pkg/serializer/serializer.go
Outdated
| func (s *serializer) encode(obj runtime.Object, mediaType string, pretty bool) ([]byte, error) { | ||
| info, ok := runtime.SerializerInfoForMediaType(s.codecs.SupportedMediaTypes(), mediaType) | ||
| if !ok { | ||
| return nil, fmt.Errorf("unable to locate encoder -- %q is not a supported media type", mediaType) |
There was a problem hiding this comment.
Replace "--" with ": " for consistency
There was a problem hiding this comment.
This was not new code; just the same as before.
| // decodable using the given serializer. However, all changes in the manifest directory, are also propagated to | ||
| // the structured data directory that's backed by the default storage implementation. Writes to this storage are | ||
| // propagated to both the manifest directory, and the data directory. | ||
| func NewTwoWayManifestStorage(manifestDir, dataDir string, ser serializer.Serializer) (*ManifestStorage, error) { |
There was a problem hiding this comment.
TwoWay might be a bit confusing as this doesn't propagate data directory changes to the manifest directory (like the name implies). Is DataManifestStorage better?
There was a problem hiding this comment.
It does propagate all the manifest that it knows about from before, so I think this is ok for now at least. We can talk about naming later.
| @@ -42,8 +40,12 @@ func NewGenericWatchStorage(s storage.Storage) (WatchStorage, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| // TODO: Fix this | |||
| gvs := s.Serializer().Scheme().PreferredVersionAllGroups() | |||
| groupName := gvs[0].Group | |||
|
Merging to get going with the gitops-toolkit extraction |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.