Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Add err as a param for log.Errorf #367

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Add err as a param for log.Errorf #367

merged 1 commit into from
Aug 30, 2019

Conversation

silenceshell
Copy link
Contributor

Add err as a param for log.Errorf.

@silenceshell silenceshell requested a review from twelho as a code owner August 27, 2019 15:54
twelho
twelho approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@twelho twelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for spotting! 👍

@twelho twelho merged commit 2c04dc5 into weaveworks:master Aug 30, 2019
@twelho twelho self-assigned this Aug 30, 2019
@twelho twelho added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 30, 2019
@twelho twelho added this to the v0.6.0 milestone Aug 30, 2019
luxas added a commit to weaveworks/libgitops that referenced this pull request Aug 30, 2019
@luxas
Port weaveworks/ignite#369 and weaveworks/ignite#367 over here
840356f
@luxas luxas changed the title add err as a param for log.Errorf Add err as a param for log.Errorf Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@twelho twelho twelho approved these changes

Assignees

@twelho twelho

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@silenceshell @twelho