This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
fix possible dm snapshot leaks #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chanwit Kaewkasi <chanwit@gmail.com>
chanwit
changed the title
chanwit
force-pushed
the
fix_possible_dm_leak
branch
2 times, most recently
from
1a37a62 to
3faa209
Compare
chanwit
changed the title
Signed-off-by: Chanwit Kaewkasi <chanwit@gmail.com>
chanwit
force-pushed
the
fix_possible_dm_leak
branch
from
3faa209 to
6704273
Compare
|
Also kindly ping @luxas |
|
Also, could we have this for 0.6.x? |
chanwit
changed the title
|
kindly ping @stealthybox |
|
I was able to replicate these issues with the dm snapshots mentioned in #365 using a build on master. This patch appears to fix it. Misplaced defer statements are a common source of error-handling issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some defers that won't be called if an error occurred by
ActivateSnapshot.It's gonna defer to
DeactivateSnapshotanyway even ifActivateSnapshotreturn an error.Signed-off-by: Chanwit Kaewkasi chanwit@gmail.com