This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Add an e2e for ignite run #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kindly ping @stealthybox if this e2e looks make sense to you, I'll continue adding more tests. |
|
Please merge #413 before this one. |
chanwit
force-pushed
the
add_e2e_ignite_run
branch
from
be41bd0 to
c5da073
Compare
stealthybox
reviewed
Sep 9, 2019
There was a problem hiding this comment.
After I rebased on master, building a fresh binary results in a passing e2e test.
We should probably incorporate this into the Makefile at some point with a dependency on the ignite binary so that a dev can just make e2e and not worry about the state of their build.
make ignite > /dev/null && echo built ignite
built ignite
sudo IGNITE_E2E_HOME=$PWD $(which go) test ./e2e/. -count 1
ok github.com/weaveworks/ignite/e2e 2.271s
sudo dmsetup ls
cryptswap (253:0)
sudo ctr -n firecracker c ls
CONTAINER IMAGE RUNTIME
docker ps
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMESI suggested a quick edit.
If you accept it, I think this a great starting point and we can merge it.
P.S: can you run make tidy-in-docker and see if you get the same vendor output?
chanwit
force-pushed
the
add_e2e_ignite_run
branch
from
c5da073 to
cbfa553
Compare
For the To run e2e tests, a dev would go with |
stealthybox
reviewed
Sep 9, 2019
Signed-off-by: Chanwit Kaewkasi <chanwit@gmail.com>
chanwit
force-pushed
the
add_e2e_ignite_run
branch
from
cbfa553 to
b4eea11
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a simple e2e test for
ignite runcommand. This one is to test under docker / docker-bridge environment. Tests for containerd / cni will be added after #411 get merged.e2e tests will be used locally at the moment for devs, and later should be with the CI when we could test them in a remote KVM environment.
This PR fixes #391