Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

improve preflight check and add a containerd test case for ignite run #416

Merged
merged 2 commits into from
Sep 11, 2019
Merged

improve preflight check and add a containerd test case for ignite run #416

merged 2 commits into from
Sep 11, 2019

Conversation

chanwit
Copy link
Member

@chanwit chanwit commented Sep 11, 2019

This PR improves pre-flight checks especially for CNI detection.
Also this PR adds an e2e test case for containerd and CNI.

@chanwit chanwit added area/testing Issues related to improving testing area/runtime Issues related to container runtimes labels Sep 11, 2019
@chanwit chanwit added this to the v0.6.1 milestone Sep 11, 2019
@chanwit chanwit requested a review from stealthybox September 11, 2019 05:10
@chanwit chanwit requested a review from twelho as a code owner September 11, 2019 05:10
@chanwit chanwit self-assigned this Sep 11, 2019
@chanwit chanwit removed the request for review from twelho September 11, 2019 05:10
@stealthybox
Copy link
Contributor

Tried this out earlier -- pre-flights look good.
Test is failing, but we're working on it
LGTM 👍

@stealthybox stealthybox merged commit 6b3b9d4 into weaveworks:master Sep 11, 2019
@chanwit chanwit added the kind/enhancement Categorizes issue or PR as related to improving an existing feature. label Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stealthybox stealthybox Awaiting requested review from stealthybox

Assignees

@chanwit chanwit

Labels
area/runtime Issues related to container runtimes area/testing Issues related to improving testing kind/enhancement Categorizes issue or PR as related to improving an existing feature.
Projects
None yet
Milestone
v0.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@chanwit @stealthybox