Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

On release, use tidy-in-docker to prevent module differences from differing versions of go #433

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

stealthybox
Copy link
Contributor

v0.5.3 deps were calculated using my on-host version of go 1.13
CircleCI picks up on this difference:
https://github.com/weaveworks/ignite/commits/v0.5.3

Running tidy-in-docker instead will use the same version of go as the build.

@stealthybox stealthybox requested a review from twelho as a code owner September 16, 2019 22:55
@chanwit chanwit requested review from chanwit and removed request for twelho September 19, 2019 02:06
@chanwit chanwit added this to the v0.6.1 milestone Sep 19, 2019
@chanwit chanwit self-assigned this Sep 19, 2019
Copy link
Member

@chanwit chanwit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chanwit chanwit merged commit d847a3a into weaveworks:master Sep 19, 2019
@stealthybox stealthybox deleted the release-tidy-in-docker branch January 16, 2020 22:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants