Teardown IPMasq rules for all actual configured bridges instead of using the hardcoded default string #461
Conversation
|
++ @najeal |
stealthybox
added
area/networking
…ing the hardcoded default string
stealthybox
force-pushed
the
generic-bridge-teardown
branch
from
dba82ba to
32a5341
Compare
|
@chanwit I consolidated the errors. I moved this cleanup into function. The error is wrapped with the util defer helper. |
| return err | ||
| } | ||
|
|
||
| cleanupErr := plugin.cleanupBridges(containerID) | ||
| if cleanupErr != nil { | ||
| defer util.DeferErr(&err, func() error { |
There was a problem hiding this comment.
why do you defer the return error?
There was a problem hiding this comment.
We can still try to remove the network if the cleanup fails.
|
PR description edit:
|
Followup #460
This logic seems to work well.
I added a trace line.
This protects us from a class of network removal bugs when stopping vm's that were created on the previous network names or CNI networks that are user configured.
You can create a vm with an old version of ignite on the
172.18/16network, stop it with this new version without error.If you remove the CNI configuration and then start it again it will be on the new
10.61/16network.This gives us our migration plan.