Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

try split resize2fs min size with both colon and full with colon #470

Closed
wants to merge 1 commit into from

Conversation

chanwit
Copy link
Member

@chanwit chanwit commented Oct 7, 2019

This PR fixes a bug when using non-English locales.
Some locales use full width colon as a separator instead of the normal colon (:)

ignite create centos:7 --name lab2 --cpus 2 --memory 2GB --ssh
INFO[0000] Docker image "centos:7" not found locally, pulling...
INFO[0038] Starting image import...
FATA[0040] strconv.ParseInt: parsing "预计文件系统的最小尺寸:61817": invalid syntax

@chanwit chanwit added the kind/bug Categorizes issue or PR as related to a bug. label Oct 7, 2019
@chanwit chanwit requested a review from stealthybox October 7, 2019 06:07
@chanwit chanwit requested a review from twelho as a code owner October 7, 2019 06:07
@chanwit chanwit removed the request for review from twelho October 7, 2019 06:11
@stealthybox
Copy link
Contributor

stealthybox commented Oct 8, 2019

Thanks for finding this!
Closing in favor of #473

@stealthybox stealthybox closed this Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants