Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Check runtime specific binary #479

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

chanwit
Copy link
Member

@chanwit chanwit commented Oct 14, 2019

There's a case that uses may install only containerd but not docker. So it's better to check only specific binaries for each runtime.

Fixes #476

@chanwit chanwit added the kind/bug Categorizes issue or PR as related to a bug. label Oct 14, 2019
@chanwit chanwit requested a review from stealthybox October 14, 2019 13:37
@chanwit chanwit requested a review from twelho as a code owner October 14, 2019 13:37
@chanwit chanwit force-pushed the check_runtime_specific_bin branch from a044c83 to 05ad564 Compare October 14, 2019 13:42
@chanwit chanwit removed the request for review from twelho October 14, 2019 13:42
@chanwit
Copy link
Member Author

chanwit commented Oct 14, 2019

/cc @sbernheim this may solve your bug

@stealthybox stealthybox merged commit 4eea805 into weaveworks:master Nov 4, 2019
@luxas luxas added this to the v0.7.0 milestone Jun 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Bin docker is not in your path" when using --runtime=containerd
3 participants