Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Add new command: ignite cp #495

Closed
wants to merge 5 commits into from
Closed

Conversation

gpauloski
Copy link
Contributor

This adds the command ignite cp <vm> <source> <dest> to copy files into a running VM.

Based on the ignite ssh implementation, ignite cp uses scp and implements the -i, -t, and -r flags.

Fixes #419

@gpauloski gpauloski requested a review from twelho as a code owner December 3, 2019 19:16
@stealthybox
Copy link
Contributor

@gpauloski, on the ignite dev call (feb3,2020) we're commenting on how useful this patch is.

@darkowlzz mentioned that he's using it for the kind integration, and that he's willing to refactor the feature with the go stdlib SSH package instead of shelling out to the host's ssh binary in the current mountNamespace.

I mentioned we should make sure to preserve your git history as he extends your patch.
Does this sound good to you?

Thanks for building this.

@gpauloski
Copy link
Contributor Author

@stealthybox Absolutely, sounds good to me.

@darkowlzz darkowlzz mentioned this pull request Mar 2, 2020
@stealthybox
Copy link
Contributor

@gpauloski Thanks so much for starting this work.
Your commits have been preserved in the history of #550.
We are planning to merge that patch.
The work you started here will be great for users :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy files from host to VM, while the VM is in running state
2 participants