Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Add loadable module for TCMU-based storage devices #497

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

croomes
Copy link
Contributor

@croomes croomes commented Dec 5, 2019

This change adds the tcm_core_user module to the kernel image.

tcm_core_user is the module providing TCMU, used by storage systems like Ceph, Gluster, Longhorn. OpenEBS and StorageOS. This will allow Pods running in Firekube to mount PVCs provisioned by these storage products.

We've been using ignite with a custom kernel for testing StorageOS but Firekube opens this up to a much wider audience, hence wanting to get this in the base image.

@croomes croomes requested a review from twelho as a code owner December 5, 2019 20:19
@croomes
Copy link
Contributor Author

croomes commented Dec 10, 2019

The test fail looks unrelated but I'm not able to re-run the test to see if was a flake.

@croomes
Copy link
Contributor Author

croomes commented Jan 28, 2020

@twelho @dholbach does this look ok?

@dholbach
Copy link
Contributor

@chanwit and @stealthybox can probably help.

@stealthybox
Copy link
Contributor

@croomes, I'm not a subject matter expert on this module, but I think this fits well into a kernel intended for kubernetes metal use.

Heads up that this may need some small edits if #506 / #511 merges first.

@stealthybox
Copy link
Contributor

👋 Thanks for this contribution @croomes

Would you be able to add and document this to the images/kernel/config-patches?
Running the build with that change on a fresh copy of master will update all of the kernel configs.

Let me know if you don't have the bandwidth.
@darkowlzz or I can carry it :)

@darkowlzz
Copy link
Contributor

darkowlzz commented Apr 25, 2020

I got permission to update the branch.

Rebased, added the TCM_USER2 config in config-patches and ran patch-config.sh to update the generated configs. Looks like the generated config files were not up-to-date with the config-patches and versioned configs. This resulted in many updates to the generated configs in addition to the TCMU configs.

@stealthybox stealthybox merged commit d941b74 into weaveworks:master Apr 27, 2020
@stealthybox
Copy link
Contributor

Thanks @croomes & @darkowlzz

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants