Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

small docs updates/fixes #505

Merged
merged 2 commits into from
Jan 2, 2020
Merged

small docs updates/fixes #505

merged 2 commits into from
Jan 2, 2020

Conversation

dholbach
Copy link
Contributor

@dholbach dholbach commented Jan 2, 2020

No description provided.

Daniel Holbach added 2 commits January 2, 2020 09:56
	fixes this warning:

	/home/daniel/go/src/github.com/weaveworks/ignite/docs/gitops.md:52: WARNING: None:any reference target not found: ../docs/installation
	/home/daniel/go/src/github.com/weaveworks/ignite/docs/gitops.md:64: WARNING: None:any reference target not found: ../docs/declarative-config
@dholbach dholbach added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 2, 2020
@dholbach dholbach requested a review from chanwit January 2, 2020 08:57
@dholbach dholbach requested a review from twelho as a code owner January 2, 2020 08:57
@dholbach dholbach self-assigned this Jan 2, 2020
@dholbach dholbach removed the request for review from twelho January 2, 2020 08:57
@dholbach dholbach changed the title smal docs updates/fixes small docs updates/fixes Jan 2, 2020
Copy link
Member

@chanwit chanwit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dholbach
Copy link
Contributor Author

dholbach commented Jan 2, 2020

Looks like https://circleci.com/gh/weaveworks/ignite/921 fails, though unrelated to this PR:

[..]
This fails if there are modified files, otherwise succeeds.
 M go.mod
 M go.sum
 M vendor/golang.org/x/crypto/internal/chacha20/asm_ppc64le.s
 M vendor/golang.org/x/crypto/internal/chacha20/chacha_noasm.go
 M vendor/golang.org/x/crypto/internal/chacha20/chacha_ppc64le.go
 M vendor/golang.org/x/crypto/ssh/common.go
 M vendor/modules.txt
[..]

@dholbach
Copy link
Contributor Author

dholbach commented Jan 2, 2020

@chanwit I guess, I'll merge this and somebody can fix the issue at hand in a separate PR?

@chanwit
Copy link
Member

chanwit commented Jan 2, 2020

Yep it's unrelated. Some of indirect dependencies changed again.

@dholbach dholbach merged commit f4e80c9 into weaveworks:master Jan 2, 2020
@dholbach dholbach deleted the docs-updates branch January 2, 2020 11:15
@luxas luxas added this to the v0.7.0 milestone Jun 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants