This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Don't fail preflight when only docker-containerd is available
#512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make ignite bin/amd64/Dockerfile e2e-nobuild \
E2E_REGEX="'DockerAndDockerBridge|Containerd'"e2e passes ^ Verified the flags are added to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
docker.iopackage in Debian 10, the containerd binary is shipped asdocker-containerdAt the moment, Ignite fails the preflight checks for this. This PR fixes this false negative.
Similarly, if
docker-containerdis available (only), then we should fall back toRuntimeLinuxV1without issuing the extra warning (not needed, it works well).This PR also propagates through the ignore-preflight-checks flag to the user, and fixes minor bugs related to this.
@stealthybox @chanwit Please review