Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Check links using GH Action #573

Merged
merged 3 commits into from
Jun 15, 2020
Merged

Check links using GH Action #573

merged 3 commits into from
Jun 15, 2020

Conversation

dholbach
Copy link
Contributor

@dholbach dholbach commented Apr 8, 2020

Breaking this out of #565

@dholbach dholbach added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 8, 2020
@dholbach dholbach mentioned this pull request Apr 8, 2020
Merged
luxas
luxas approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we'll soon merge the dependent PR and get back to this.

@luxas
Copy link
Contributor

luxas commented Apr 10, 2020

@dholbach this should be ready to rebase and merge now

@dholbach dholbach force-pushed the check-links branch 10 times, most recently from bc622fc to d4ef106 Compare April 15, 2020 14:44
@dholbach dholbach force-pushed the check-links branch 3 times, most recently from 94c720d to 571245b Compare April 30, 2020 07:57
@luxas
Copy link
Contributor

luxas commented Jun 8, 2020

@dholbach if you have time to get back to this (rebase & make it green) I'll help you get it merged ASAP 😄

@dholbach
Copy link
Contributor Author

dholbach commented Jun 8, 2020

Unfortunately it's not so easy. The ignite docs are essentially a link-farm and we get rate-limited from e.g. Github after checking all these links.

@dholbach dholbach force-pushed the check-links branch 7 times, most recently from 0bc1ecf to 9ebb528 Compare June 9, 2020 13:29
@dholbach
Copy link
Contributor Author

dholbach commented Jun 9, 2020

I need help fixing the remaining bit:

 site/api/ignite_v1alpha1/index.html
	ERROR	https://github.com/weaveworks/ignite/tree/master/pkg/apis/ignite/v1alpha1/types.go?s=8278:8315#L226
		Too Many Requests (HTTP error 429)
site/api/ignite_v1alpha2/index.html
	ERROR	https://github.com/weaveworks/ignite/tree/master/pkg/apis/ignite/v1alpha2/types.go?s=7227:7371#L189
		Too Many Requests (HTTP error 429)

It's too many requests. Github is not happy.

cc @luxas

@luxas
Copy link
Contributor

luxas commented Jun 11, 2020

Hmm, I'm not sure what to do about it :(

@dholbach dholbach marked this pull request as ready for review June 12, 2020 10:25
@dholbach dholbach requested a review from stealthybox as a code owner June 12, 2020 10:25
@dholbach
Copy link
Contributor Author

Looks like it is passing this time. 🤞

@dholbach dholbach requested a review from luxas June 12, 2020 10:26
luxas
luxas approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, things are greeeeen 🌴 💯 😄
Thanks!

@luxas luxas merged commit aedb9cd into master Jun 15, 2020
@dholbach dholbach deleted the check-links branch June 15, 2020 07:34
@dholbach dholbach mentioned this pull request Jun 15, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luxas luxas luxas approved these changes

@stealthybox stealthybox Awaiting requested review from stealthybox

Assignees
No one assigned
Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dholbach @luxas