Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Filter loopback IPs from VM metadata to prevent SSH related test flakes #581

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

stealthybox
Copy link
Contributor

@stealthybox stealthybox commented Apr 13, 2020

(also, this just makes sense)
discussed with @darkowlzz
we see no use-case for reporting that VMs have loopback IPs at an API level

(also, this just makes sense)
discussed with @darkowlzz
we see no use-case for reporting that VMs have loopback IPs at an API level
@stealthybox stealthybox requested a review from twelho as a code owner April 13, 2020 17:44
@stealthybox stealthybox changed the title Filter loopback IPs from VM metadata to prevent SSH related test flakes (also, this just makes sense) discussed with @darkowlzz we see no use-case for reporting that VMs have loopback IPs at an API level Filter loopback IPs from VM metadata to prevent SSH related test flakes Apr 13, 2020
@stealthybox stealthybox merged commit aa1e6de into weaveworks:master Apr 13, 2020
@stealthybox stealthybox deleted the filter_ssh_loopback branch April 13, 2020 17:58
This was referenced Apr 13, 2020
@luxas luxas added this to the v0.7.0 milestone Jun 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants