Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Fix image platform for arm image #636

Merged
merged 1 commit into from
Jul 26, 2020
Merged

Conversation

leakingtapan
Copy link

Fix: #345

Fixing the multi-arch container image build by properly annotate the image manifest for each architectures (arm64 and amd64). So that the image platform is correct.

Testing
Built test image and pushed to my personal dockerhub registry:

docker manifest inspect chengpan/ignite:v0.7.0-25-9c998301147a44-arm64
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
   "manifests": [
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 529,
         "digest": "sha256:81d44b341961ca83f74fcaad5b88f6750413f4de96b20df561566cf3af8ec5ce",
         "platform": {
            "architecture": "arm64",
            "os": "linux"
         }
      }
   ]
}

@leakingtapan leakingtapan requested a review from stealthybox as a code owner July 7, 2020 06:35
@leakingtapan
Copy link
Author

@stealthybox the doc site link check seems an existing issue

@stealthybox
Copy link
Contributor

@leakingtapan yes -- don't worry about the link checker 👍

Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the manifest for the images at the end LGTM!

Thanks for fixing it.

@darkowlzz darkowlzz merged commit 27dffa4 into weaveworks:master Jul 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

weaveworks/ignite:<version>-arm64 images have amd64 as their architecture
3 participants