Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Upgrade firecracker to v0.22.4 #797

Merged
merged 4 commits into from
Mar 8, 2021
Merged

Upgrade firecracker to v0.22.4 #797

merged 4 commits into from
Mar 8, 2021

Conversation

gaby
Copy link
Contributor

@gaby gaby commented Mar 5, 2021

This PR takes care of upgrading firecracker from v0.22.1 to v0.22.4

Review of firecracker changes:

v0.22.2

  • Fixed inconsistency in YAML file InstanceInfo definition

v0.22.3

  • Fixed off-by-one error in virtio-block descriptor address validation.

v0.22.4

  • Fixed the reported used bytes for any virtio-block request.
  • Fixed all virtio-block read/write operations to valid guest addresses
    with buffer length of 0 to result in no-op.

Update firecracker to 0.22.4
gaby added 2 commits March 5, 2021 01:21
Updated Dockerfile to process the new format of Firecracker releases.
Remove output path from wget command
@darkowlzz
Copy link
Contributor

Thanks for updating the firecracker version. The changes look good to me. Can you also update the installation docs to reflect this change? https://github.com/weaveworks/ignite/blob/master/docs/installation.md#ignite-cli - firecracker version in the output.
Also, maybe squash the commits if possible 🙂

@darkowlzz darkowlzz added the area/dependency Issues or PRs related to dependency changes label Mar 8, 2021
Update installation.md
@gaby
Copy link
Contributor Author

gaby commented Mar 8, 2021

@darkowlzz Done, I'm using Github Desktop app and it doesn't have an option for squashing commits. I know there's an option to do it here via the PR but i don't see it on this repo.

@darkowlzz
Copy link
Contributor

@darkowlzz Done, I'm using Github Desktop app and it doesn't have an option for squashing commits. I know there's an option to do it here via the PR but i don't see it on this repo.

That's okay. np.

@stealthybox stealthybox merged commit 59b93df into weaveworks:master Mar 8, 2021
@stealthybox
Copy link
Contributor

Thank you for all of this incredible work.
This is significant maintenance effort to track all the dependencies -- we really appreciate it.

@gaby gaby deleted the upgrade-firecracker branch March 25, 2021 04:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/dependency Issues or PRs related to dependency changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants