This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
is_git_repo: Return without echo #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was resulting in GIT_VERSION to be ".git v0.8.0-87+b5214a06643efb-dirty" and causing errors like `/bin/bash: line 1: v0.8.0-87+b5214a06643efb-dirty: command not found` when building ignite. Instead of echo-ing, this returns 0 - true from the function.
darkowlzz
requested review from
chanwit,
luxas,
stealthybox and
twelho
as code owners
|
tyvm for my shortsighted bashisms |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was resulting in
GIT_VERSIONto be".git v0.8.0-87+b5214a06643efb-dirty"and causing errors like/bin/bash: line 1: v0.8.0-87+b5214a06643efb-dirty: command not foundwhen building ignite.
Instead of echo-ing, this returns 0 - true from the function.
To reproduce, run
makeand notice the first line:Introduced in e3add4e recently where we were trying to help improve the AUR package build from tarballs.