Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Ignore not found error while deactivating snapshot #823

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

darkowlzz
Copy link
Contributor

While deleting a VM, if the associated device mapper device has been
already deleted and cannot be found, the delete should continue without
any error.

Based on:

sudo bin/ignite vm rm -f young-surf
FATA[0000] command ["dmsetup" "remove" "--verifyudev" "ignite-bb967b1753deda1e"] exited with "device-mapper: remove ioctl on ignite-bb967b1753deda1e  failed: No such device or address\nCommand failed.\n": exit status 1

While deleting a VM, if the associated device mapper device has been
already deleted and cannot be found, the delete should continue without
any error.
@darkowlzz darkowlzz added the kind/enhancement Categorizes issue or PR as related to improving an existing feature. label Apr 18, 2021
@stealthybox stealthybox merged commit 8b31ad7 into weaveworks:master Apr 19, 2021
@stealthybox
Copy link
Contributor

stealthybox commented Apr 19, 2021

Reproduced locally -- verified this fixes the issue I was seeing.
My system is a WSL2 container. It doesn't have udevd which may be why Sunny can't reproduce but I can.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants