This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Add client config option + registry auth e2e tests #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a --client-config-dir flag in VM create, image import and kernel import subcommands. - Adds field clientConfigDir in ignite configuration. - Update v1alpha4 API and add custom conversion function for v1alpha3.
darkowlzz
requested review from
chanwit,
luxas,
stealthybox and
twelho
as code owners
- Adds setup-private-registry.sh script to setup a local docker registry with self-signed cert and basic auth. - Adds test util to delete image from ignite and the runtime content store. - Adds e2e tests for image import with configurations set via flag and ignite configuration. - Enable docker registry setup only in semaphore CI for e2e tests. - Update go version in semaphore to 1.16.3 to use os.WriteFile().
darkowlzz
force-pushed
the
client-config-dir
branch
from
7ff29e0 to
12e0919
Compare
darkowlzz
added
area/testing
stealthybox
reviewed
May 24, 2021
stealthybox
reviewed
May 24, 2021
stealthybox
reviewed
May 24, 2021
…nd TLS-ignore-verify /w tests :) Co-Authored-By: Sunny <darkowlzz@protonmail.com>
stealthybox
force-pushed
the
client-config-dir
branch
from
8db753a to
db2150d
Compare
|
It's good to see the test runtime for this is actually quite good on Semaphore. 36s - Registry Setup 1m02s |
This mainly checks if the remote resolver enforces the usage of insecure registries when the registry server address is http.
TestPullFromAuthRegistry executes the script to set up the registries at the beginning and stop the registries at the end of the test. Remove registry setup from semaphore
darkowlzz
force-pushed
the
client-config-dir
branch
from
006d13d to
8b9f487
Compare
When the registry set up script is execited from the go e2e tests, it modified the user's default docker config permissions. Use a test config directory to avoid modifying the default docker configuration file.
darkowlzz
force-pushed
the
client-config-dir
branch
from
8b9f487 to
a56e739
Compare
|
🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--registry-config-dirflag in VM create, image import and kernelimport subcommands.
registryConfigDirin ignite configuration.setup-private-registry.shscript to setup a local docker registrywith self-signed cert and basic auth.
store.
ignite configuration.
os.WriteFile().Follow-up of #833
TODO: