Add DNS status check #160
Closed
Add DNS status check #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes DNS is not configured correctly, mainly on minikube Kubernetes clusters. This checks that the DNS deployment has all the running pods, if not it errors out and suggests to the user to correctly setup DNS.
leth
reviewed
Apr 5, 2018
| // We exit if the DNS pods are not up and running, as the installer needs to be | ||
| // able to connect to the server to correctly setup the needed resources. | ||
| if !dns { | ||
| fmt.Println("WARNING: DNS pods are not up and running, launcher requires correct DNS setup in the Kubernetes cluster.") |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
dlespiau
reviewed
Apr 5, 2018
There was a problem hiding this comment.
Trying to summarise the discussion that happened in slack:
- Currently this will have false positives when installing on a cluster running an alternate DNS provider like coreDNS
- We could add a "are we running on minikube" condition to restrict the check, but this can also lead to some false positives, consider:
minikube addons disable kube-dns
kubectl apply -f coredns.yaml
- We could try to do some "pre-flight" checks on the kubernetes cluster (and clean up what we did) to check if things are working ok, in this case we are interested in DNS so we could do, something along the lines of:
kubectl run --namespace=weave --image=busybox --command launcher-pre-flight nslookup cloud.weave.work
and check the status of the pod. Hopefully we can find a nicer way to start a pod and get the exit status of the init process.
| @@ -121,6 +129,27 @@ func DeleteResource(c Client, resourceType, namespace, resourceName string) erro | |||
| return err | |||
| } | |||
|
|
|||
| // DeploymentAvailability gets the current deployment status and returs true if all the replicas are up and running. | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Closing in favor of #164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes DNS is not configured correctly, mainly on minikube
Kubernetes clusters. This checks that the DNS deployment has all
the running pods, if not it errors out and suggests to the user
to correctly setup DNS.
Fixes #158
Notes: