Add DNS check to bootstrap #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlespiau
approved these changes
Apr 10, 2018
bootstrap/main.go
Outdated
| // We exit if the DNS pods are not up and running, as the installer needs to be | ||
| // able to connect to the server to correctly setup the needed resources. | ||
| if !ok { | ||
| exitWithCapture("DNS is not working in this Kubernetes cluster. We require correct DNS setup in the Kubernetes cluster.") |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
pkg/kubectl/kubectl.go
Outdated
| return err | ||
| } | ||
|
|
||
| err = json.Unmarshal([]byte(oJSON), &o) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sometimes DNS is not configured correctly, but during the launcher process DNS is required to setup all the needed resources. This creates a check by creating a pod where nslookup is performed.
leth
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes DNS is not configured correctly, but during the launcher
process, DNS is required to setup all the needed resources. This creates
a check by creating a pod where nslookup is performed.
Closes #158.
Tests were not running on the old PR, so this is more or less a duplicate of #164.