This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
Move Storage.New() -> Serializer.Defaulter().NewDefaultedObject() #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twelho
approved these changes
Aug 21, 2020
pkg/serializer/defaulter.go
Outdated
| @@ -13,6 +14,23 @@ type defaulter struct { | |||
| scheme *runtime.Scheme | |||
| } | |||
|
|
|||
| // NewDefaultedObject returns a new, defaulted object. It is essentially scheme.New() and | |||
| // scheme.Default(obj), but with extra logic to cover also internal versions. | |||
There was a problem hiding this comment.
also cover internal versions
pkg/serializer/defaulter.go
Outdated
| @@ -13,6 +14,23 @@ type defaulter struct { | |||
| scheme *runtime.Scheme | |||
| } | |||
|
|
|||
| // NewDefaultedObject returns a new, defaulted object. It is essentially scheme.New() and | |||
| // scheme.Default(obj), but with extra logic to cover also internal versions. | |||
| // Important to note here is that the TypeMeta information is NOT applied automatically here. | |||
There was a problem hiding this comment.
Redundant here at the end of the sentence.
|
comments fixed. merging :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to re-organize code where it fits better. Creating defaulted objects isn't really what the storage should be doing.
Notes: The old storage implementation relied heavily on objects always having their
TypeMetaset.Unfortunately, that is pretty brittle, and error prone, so in the moved code, we start progressively re-structuring code
so that it doesn't assume that, but instead use
GVKForObjectwhen needed.cc @twelho @chanwit @stealthybox