Tweak some coefficients #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a 3-node cluster would send to 1 peer each time, and a 7-node cluster to 2, so information could take a while to get everywhere. This calculation maintains the spirit that the number grows slowly in larger clusters - in a 100-node cluster each node will gossip to 12.
When 100 connections arrive at once, each one sends the whole topology and we read it all into memory at once then try to relay new information out again. These new parameters mean we will take 4 seconds to accept 100 connections, and 9 seconds to accept 200, so the system has time to process each message without spiking memory.
rade
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double the number of neighbours we gossip to, for improved coverage.
Previously a 3-node cluster would send to 1 peer each time, and a 7-node cluster to 2, so information could take a while to get everywhere.
This calculation maintains the spirit that the number grows slowly in larger clusters - in a 100-node cluster each node will gossip to 12.
Slow down accepting new connections, to reduce peak memory usage.
When 100 connections arrive at once, each one sends the whole topology and we read it all into memory at once then try to relay new information out again.
These new parameters mean we will take 4 seconds to accept 100 connections, and 9 seconds to accept 200, so the system has time to process each message without spiking memory.