Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status: report actual min protocol version #89

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

itizir
Copy link
Contributor

@itizir itizir commented Nov 28, 2018

Hi!
Just a minor thing, but when getting the status of weave, it always reports Protocol: weave 1..2, which isn't particularly useful...

@bboreham
Copy link
Contributor

What does it report after your change?

@itizir
Copy link
Contributor Author

itizir commented Nov 29, 2018

It would report the min protocol version set in the router, which is relevant when querying weave for its status (https://github.com/weaveworks/weave/blob/master/site/troubleshooting.md).

Would be useful to be able to easily check whether weave has been started with --min-protocol-version=2, which is necessary for security. But as things are, the Protocol printout in the status is hardcoded to 1..2.

I'm also noticing now that the NewRouter function in mesh does not check the set min version is valid (within bounds)... Worth changing that, too?

@bboreham
Copy link
Contributor

bboreham commented Feb 4, 2019

Sorry, lost track of this.
Having looked at the code, I think the underlying point is the min version is configurable by user of this library, so we should print out what they configured. So LGTM, thanks!

@bboreham bboreham merged commit 512bdb7 into weaveworks:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants