Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release version 2.3.0 #146

Merged
merged 11 commits into from
Feb 19, 2023
Merged

release version 2.3.0 #146

merged 11 commits into from
Feb 19, 2023

Conversation

ahsayde
Copy link
Contributor

@ahsayde ahsayde commented Feb 19, 2023

Closes
#140
#141

What changed?

  • Support targeting workspaces in policy config
  • Add status field to policy config CR to detect missing policies

Why was this change made?

  • Support targeting workspaces in policy config
  • Make it easy to detect missing policies included in policy configs

How was this change implemented?

  • Implement a controller for policy config CR

How did you validate the change?

  • added unit tests

Release notes

Documentation Changes

waleedhammam and others added 11 commits February 19, 2023 14:38
* add new field status for policy config crd

* add test cases

* update with pr comments

* add policy status subresource

* add policy status subresource

* rename policy ids

* remove unused variable

* increase the threshould of codecov

* fix missing policies and add status print field

* add age field
Co-authored-by: serboctor <boctor.sarah@gmail.com>
support targetting workspaces in policy config
@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Merging #146 (3410e49) into master (12e8e0c) will decrease coverage by 2.06%.
The diff coverage is 55.05%.

❗ Current head 3410e49 differs from pull request most recent head 439a514. Consider uploading reports for the commit 439a514 to get more accurate results

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
- Coverage   80.86%   78.80%   -2.06%     
==========================================
  Files          14       14              
  Lines         831      906      +75     
==========================================
+ Hits          672      714      +42     
- Misses        120      144      +24     
- Partials       39       48       +9     
Flag Coverage Δ
unit 78.80% <55.05%> (-2.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/policy_controller.go 71.87% <ø> (+2.17%) ⬆️
controllers/policyconfig_controller.go 57.98% <44.92%> (-11.11%) ⬇️
internal/policies/policyconfig.go 89.61% <84.61%> (-4.24%) ⬇️
internal/policies/test_utils.go 100.00% <100.00%> (+33.33%) ⬆️
internal/policies/policy.go 85.00% <0.00%> (-2.50%) ⬇️
internal/sink/elastic/elastic.go 65.59% <0.00%> (+2.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@serboctor serboctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahsayde ahsayde merged commit d948f04 into master Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants