Merge pull request #1283 from weaveworks/1282-plugin-panic

Don't add plugin registry if creating it fails
weaveworks · Apr 13, 2016 · 12b4074 · 12b4074
2 parents b74b394 + a171dd2
commit 12b4074
Showing 1 changed file with 14 additions and 14 deletions.
diff --git a/prog/probe.go b/prog/probe.go
@@ -115,19 +115,6 @@ func probeMain() {
 	log.Infof("probe starting, version %s, ID %s", version, probeID)
 	go check()
 
-	pluginRegistry, err := plugins.NewRegistry(
-		*pluginsRoot,
-		pluginAPIVersion,
-		map[string]string{
-			"probe_id":    probeID,
-			"api_version": pluginAPIVersion,
-		},
-	)
-	if err != nil {
-		log.Errorf("plugins: problem loading: %v", err)
-	}
-	defer pluginRegistry.Close()
-
 	if len(flag.Args()) > 0 {
 		targets = flag.Args()
 	}
@@ -206,7 +193,20 @@ func probeMain() {
 		}
 	}
 
-	p.AddReporter(pluginRegistry)
+	pluginRegistry, err := plugins.NewRegistry(
+		*pluginsRoot,
+		pluginAPIVersion,
+		map[string]string{
+			"probe_id":    probeID,
+			"api_version": pluginAPIVersion,
+		},
+	)
+	if err != nil {
+		log.Errorf("plugins: problem loading: %v", err)
+	} else {
+		defer pluginRegistry.Close()
+		p.AddReporter(pluginRegistry)
+	}
 
 	if *httpListen != "" {
 		go func() {