Skip to content

Commit

Permalink
Merge pull request #3171 from weaveworks/add-opencontainers-labels-to…
Browse files Browse the repository at this point in the history
…-dockerfiles

Add org.opencontainers.image.* labels to Dockerfiles
  • Loading branch information
marccarre authored May 14, 2018
2 parents daccb66 + 4e58b83 commit 206aa5c
Show file tree
Hide file tree
Showing 16 changed files with 103 additions and 13 deletions.
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ SCOPE_UI_BUILD_UPTODATE=.scope_ui_build.uptodate
SCOPE_BACKEND_BUILD_IMAGE=$(DOCKERHUB_USER)/scope-backend-build
SCOPE_BACKEND_BUILD_UPTODATE=.scope_backend_build.uptodate
SCOPE_VERSION=$(shell git rev-parse --short HEAD)
GIT_REVISION=$(shell git rev-parse HEAD)
WEAVENET_VERSION=2.1.3
RUNSVINIT=vendor/runsvinit/runsvinit
CODECGEN_DIR=vendor/github.com/ugorji/go/codec/codecgen
Expand Down Expand Up @@ -56,7 +57,7 @@ docker/%: %
cp $* docker/

%.tar: docker/Dockerfile.%
$(SUDO) docker build -t $(DOCKERHUB_USER)/$* -f $< docker/
$(SUDO) docker build --build-arg=revision=$(GIT_REVISION) -t $(DOCKERHUB_USER)/$* -f $< docker/
$(SUDO) docker tag $(DOCKERHUB_USER)/$* $(DOCKERHUB_USER)/$*:$(IMAGE_TAG)
$(SUDO) docker save $(DOCKERHUB_USER)/$*:latest > $@

Expand Down
7 changes: 7 additions & 0 deletions backend/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,10 @@ RUN go get -tags netgo \
RUN pip install yapf==0.16.2 flake8==3.3.0
COPY build.sh /
ENTRYPOINT ["/build.sh"]

ARG revision
LABEL maintainer="Weaveworks <help@weave.works>" \
org.opencontainers.image.title="backend" \
org.opencontainers.image.source="https://github.com/weaveworks/scope/tree/master/backend" \
org.opencontainers.image.revision="${revision}" \
org.opencontainers.image.vendor="Weaveworks"
7 changes: 7 additions & 0 deletions client/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,10 @@ COPY package.json yarn.lock /home/weave/
ENV NPM_CONFIG_LOGLEVEL=warn NPM_CONFIG_PROGRESS=false
RUN yarn --pure-lockfile
COPY webpack.local.config.js webpack.production.config.js server.js .babelrc .eslintrc .eslintignore .stylelintrc .sass-lint.yml /home/weave/

ARG revision
LABEL maintainer="Weaveworks <help@weave.works>" \
org.opencontainers.image.title="client" \
org.opencontainers.image.source="https://github.com/weaveworks/scope" \
org.opencontainers.image.revision="${revision}" \
org.opencontainers.image.vendor="Weaveworks"
10 changes: 8 additions & 2 deletions docker/Dockerfile.cloud-agent
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
FROM alpine:3.5
LABEL maintainer="Weaveworks Inc <help@weave.works>"
LABEL works.weave.role=system
WORKDIR /home/weave
RUN apk add --update bash conntrack-tools iproute2 util-linux curl && \
rm -rf /var/cache/apk/*
ADD ./weave ./weaveutil /usr/bin/
COPY ./scope /home/weave/
ENTRYPOINT ["/home/weave/scope", "--mode=probe", "--no-app", "--probe.docker=true"]

ARG revision
LABEL works.weave.role="system" \
maintainer="Weaveworks <help@weave.works>" \
org.opencontainers.image.title="cloud-agent" \
org.opencontainers.image.source="https://github.com/weaveworks/scope" \
org.opencontainers.image.revision="${revision}" \
org.opencontainers.image.vendor="Weaveworks"
7 changes: 7 additions & 0 deletions docker/Dockerfile.scope
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,10 @@ COPY ./run-app /etc/service/app/run
COPY ./run-probe /etc/service/probe/run
EXPOSE 4040
ENTRYPOINT ["/home/weave/entrypoint.sh"]

ARG revision
LABEL maintainer="Weaveworks <help@weave.works>" \
org.opencontainers.image.title="scope" \
org.opencontainers.image.source="https://github.com/weaveworks/scope" \
org.opencontainers.image.revision="${revision}" \
org.opencontainers.image.vendor="Weaveworks"
7 changes: 7 additions & 0 deletions extras/dialer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,2 +1,9 @@
FROM golang:1.7
ADD ./bin/dialer /go/bin

ARG revision
LABEL maintainer="Weaveworks <help@weave.works>" \
org.opencontainers.image.title="dialer" \
org.opencontainers.image.source="https://github.com/weaveworks/scope/tree/master/extras/dialer" \
org.opencontainers.image.revision="${revision}" \
org.opencontainers.image.vendor="Weaveworks"
3 changes: 2 additions & 1 deletion extras/example/Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
CC=gcc
CFLAGS=-g -lpthread
BUILD_IN_CONTAINER=true
GIT_REVISION := $(shell git rev-parse HEAD)

all: .qotd.marker .app.marker .client.marker .searchapp.marker .shout.marker .frontend.marker .frontend-k8s.marker .echo.marker .trace_app.marker

Expand Down Expand Up @@ -33,7 +34,7 @@ endif
.echo.marker: echo/*
.trace_app.marker: trace_app/*
.%.marker:
docker build -t tomwilkie/$(<D) $(<D)/
docker build --build-arg=revision=$(GIT_REVISION) -t tomwilkie/$(<D) $(<D)/
touch $@

clean:
Expand Down
8 changes: 7 additions & 1 deletion extras/example/app/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
FROM tatsushid/tinycore-python:2.7
LABEL maintainer="Weaveworks Inc <help@weave.works>"
WORKDIR /home/weave
ADD requirements.txt /home/weave/
RUN pip install -r /home/weave/requirements.txt
ADD app.py /home/weave/
EXPOSE 5000
ENTRYPOINT ["python", "/home/weave/app.py"]

ARG revision
LABEL maintainer="Weaveworks <help@weave.works>" \
org.opencontainers.image.title="example-app" \
org.opencontainers.image.source="https://github.com/weaveworks/scope/tree/master/extras/example/app" \
org.opencontainers.image.revision="${revision}" \
org.opencontainers.image.vendor="Weaveworks"
8 changes: 7 additions & 1 deletion extras/example/client/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
FROM tatsushid/tinycore-python:2.7
LABEL maintainer="Weaveworks Inc <help@weave.works>"
WORKDIR /home/weave
ADD requirements.txt /home/weave/
RUN pip install -r /home/weave/requirements.txt
ADD client.py /home/weave/
ENTRYPOINT ["python", "/home/weave/client.py"]

ARG revision
LABEL maintainer="Weaveworks <help@weave.works>" \
org.opencontainers.image.title="example-client" \
org.opencontainers.image.source="https://github.com/weaveworks/scope/tree/master/extras/example/client" \
org.opencontainers.image.revision="${revision}" \
org.opencontainers.image.vendor="Weaveworks"
8 changes: 7 additions & 1 deletion extras/example/echo/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
FROM tatsushid/tinycore-python:2.7
LABEL maintainer="Weaveworks Inc <help@weave.works>"
WORKDIR /home/weave
ADD requirements.txt /home/weave/
RUN pip install -r /home/weave/requirements.txt
ADD echo.py /home/weave/
EXPOSE 5000
ENTRYPOINT ["python", "/home/weave/echo.py"]

ARG revision
LABEL maintainer="Weaveworks <help@weave.works>" \
org.opencontainers.image.title="example-echo" \
org.opencontainers.image.source="https://github.com/weaveworks/scope/tree/master/extras/example/echo" \
org.opencontainers.image.revision="${revision}" \
org.opencontainers.image.vendor="Weaveworks"
8 changes: 7 additions & 1 deletion extras/example/frontend-k8s/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
FROM ubuntu
LABEL maintainer="Weaveworks Inc <help@weave.works>"
RUN apt-get update && \
apt-get install -y nginx && \
rm -rf /var/lib/apt/lists/*
Expand All @@ -9,3 +8,10 @@ RUN rm /etc/nginx/sites-available/default && \
COPY default.conf /etc/nginx/conf.d/
EXPOSE 80
CMD ["nginx", "-g", "daemon off;"]

ARG revision
LABEL maintainer="Weaveworks <help@weave.works>" \
org.opencontainers.image.title="example-frontend-k8s" \
org.opencontainers.image.source="https://github.com/weaveworks/scope/tree/master/extras/example/frontend-k8s" \
org.opencontainers.image.revision="${revision}" \
org.opencontainers.image.vendor="Weaveworks"
8 changes: 7 additions & 1 deletion extras/example/frontend/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
FROM ubuntu
LABEL maintainer="Weaveworks Inc <help@weave.works>"
RUN apt-get update && \
apt-get install -y nginx && \
rm -rf /var/lib/apt/lists/*
Expand All @@ -9,3 +8,10 @@ RUN rm /etc/nginx/sites-available/default && \
COPY default.conf /etc/nginx/conf.d/
EXPOSE 80
CMD ["nginx", "-g", "daemon off;"]

ARG revision
LABEL maintainer="Weaveworks <help@weave.works>" \
org.opencontainers.image.title="example-frontend" \
org.opencontainers.image.source="https://github.com/weaveworks/scope/tree/master/extras/example/frontend" \
org.opencontainers.image.revision="${revision}" \
org.opencontainers.image.vendor="Weaveworks"
8 changes: 7 additions & 1 deletion extras/example/qotd/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
FROM ubuntu
LABEL maintainer="Weaveworks Inc <help@weave.works>"
WORKDIR /home/weave
ADD ./qotd /home/weave/
EXPOSE 4446
ENTRYPOINT ["/home/weave/qotd"]

ARG revision
LABEL maintainer="Weaveworks <help@weave.works>" \
org.opencontainers.image.title="example-qotd" \
org.opencontainers.image.source="https://github.com/weaveworks/scope/tree/master/extras/example/qotd" \
org.opencontainers.image.revision="${revision}" \
org.opencontainers.image.vendor="Weaveworks"
8 changes: 7 additions & 1 deletion extras/example/searchapp/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
FROM progrium/busybox
LABEL maintainer="Weaveworks Inc <help@weave.works>"
WORKDIR /home/weave
ADD searchapp /home/weave/
EXPOSE 8080
ENTRYPOINT ["/home/weave/searchapp"]

ARG revision
LABEL maintainer="Weaveworks <help@weave.works>" \
org.opencontainers.image.title="example-searchapp" \
org.opencontainers.image.source="https://github.com/weaveworks/scope/tree/master/extras/example/searchapp" \
org.opencontainers.image.revision="${revision}" \
org.opencontainers.image.vendor="Weaveworks"
8 changes: 7 additions & 1 deletion extras/example/shout/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
FROM alpine:latest
LABEL maintainer="Weaveworks Inc <help@weave.works>"
WORKDIR /home/weave
ADD shout /home/weave/
EXPOSE 8090
ENTRYPOINT ["/home/weave/shout"]

ARG revision
LABEL maintainer="Weaveworks <help@weave.works>" \
org.opencontainers.image.title="example-shout" \
org.opencontainers.image.source="https://github.com/weaveworks/scope/tree/master/extras/example/shout" \
org.opencontainers.image.revision="${revision}" \
org.opencontainers.image.vendor="Weaveworks"
8 changes: 7 additions & 1 deletion extras/example/trace_app/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
FROM tatsushid/tinycore-python:2.7
LABEL maintainer="Weaveworks Inc <help@weave.works>"
WORKDIR /home/weave
ADD requirements.txt /home/weave/
RUN pip install -r /home/weave/requirements.txt
ADD app.py /home/weave/
EXPOSE 5000
ENTRYPOINT ["python", "/home/weave/app.py"]

ARG revision
LABEL maintainer="Weaveworks <help@weave.works>" \
org.opencontainers.image.title="example-trace_app" \
org.opencontainers.image.source="https://github.com/weaveworks/scope/tree/master/extras/example/trace_app" \
org.opencontainers.image.revision="${revision}" \
org.opencontainers.image.vendor="Weaveworks"

0 comments on commit 206aa5c

Please sign in to comment.