Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make node outer border stroke consistent width #1080

Closed
pidster opened this issue Mar 1, 2016 · 1 comment · Fixed by #1120
Closed

Make node outer border stroke consistent width #1080

pidster opened this issue Mar 1, 2016 · 1 comment · Fixed by #1120
Labels
component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer

Comments

@pidster
Copy link
Contributor

pidster commented Mar 1, 2016

Single node borders are thicker than the border on a stack.
The single node should use the same smaller value for border width as the stack.

thick

thin-stack
@pidster pidster added the component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer label Mar 1, 2016
@davkal
Copy link
Contributor

davkal commented Mar 1, 2016

Just tried it. They look too heavy.

Single:
screen shot 2016-03-01 at 16 18 57

Stack original:

screen shot 2016-03-01 at 16 21 20

Stack 1px thicker, spacing increased by 2px:
screen shot 2016-03-01 at 16 19 32

Visually, I'd vote against it.
WDYT @foot ?
Is there another aspect? @pidster

davkal added a commit that referenced this issue Mar 4, 2016
@davkal
Adjust node borders
53d8731 
* increase stack node borders by 0.5px (fixes #1080)
* space out stacks in contrast mode (fixes #1020)
* fix cloud border stroke-width setting (exlude from CSS styling)
* adjust cloud border for contrast mode
@davkal davkal mentioned this issue Mar 4, 2016
Merged
davkal added a commit that referenced this issue Mar 7, 2016
@davkal
Slightly thinner borders on nodes
c1c16e1 
* epilogue to #1080
* slightly thinner borders are more in line with, ehem, other lines
@davkal davkal mentioned this issue Mar 7, 2016
Merged
foot pushed a commit that referenced this issue Mar 10, 2016
@davkal @foot
Adjust node borders
d7561d2 
* increase stack node borders by 0.5px (fixes #1080)
* space out stacks in contrast mode (fixes #1020)
* fix cloud border stroke-width setting (exlude from CSS styling)
* adjust cloud border for contrast mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust node borders weaveworks/scope
2 participants
@pidster @davkal