Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipe websocket leak in Scope App #1189

Closed
2opremio opened this issue Mar 21, 2016 · 6 comments
Closed

Pipe websocket leak in Scope App #1189

2opremio opened this issue Mar 21, 2016 · 6 comments
Labels
bug Broken end user or developer functionality; not working as the developers intended it
Milestone
0.14.0

Comments

@2opremio
Copy link
Contributor

Profile: inuse_objects.inuse_space.001.pb.gz

scope_app_heap

492MB worth of sockets may indicate some other problem with connections (e.g. infinite reconnection loop).

Context: https://weaveworks.slack.com/archives/scope-public/p1458051757000002
@2opremio 2opremio added the bug Broken end user or developer functionality; not working as the developers intended it label Mar 21, 2016
@2opremio 2opremio added this to the 0.14.0 milestone Mar 21, 2016
@2opremio
Copy link
Contributor Author

From the user:

lots of Error copying to pipe pipe-2448387299974790848 (1) websocket: websocket: close 1006 (abnormal closure): unexpected EOF

https://weaveworks.slack.com/archives/scope-public/p1458570896000146

@rade
Copy link
Member

rade commented Mar 21, 2016

Same as #1131?

@2opremio
Copy link
Contributor Author

Most probably. @rade can you easily reproduce? It would be useful to run weaveworks/scope:latest to see if #1172 fixes it.

@rade
Copy link
Member

rade commented Mar 21, 2016

@rade can you easily reproduce?

Nope :(

@2opremio
Copy link
Contributor Author

The user (@janwillies) deployed weaveworks/scope:latest hoping that #1172 would have resolved it and the results are positive so far. It has only been running for 7 hours but there are no signs of the leak

pprof.localhost_4040.inuse_objects.inuse_space.001.pb.gz

app_heap_profile

$ go tool pprof --focus 'websocket\.newConn' -png pprof.localhost_4040.inuse_objects.inuse_space.001.pb.gz > app_heap_profile_newConn.png
Focus expression matched no samples: websocket\.newConn

@2opremio 2opremio mentioned this issue Mar 23, 2016
Closed
@davkal
Copy link
Contributor

davkal commented Apr 5, 2016

Positive is good enough.

@davkal davkal closed this as completed Apr 5, 2016
@rade rade mentioned this issue Aug 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Broken end user or developer functionality; not working as the developers intended it
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
3 participants
@rade @davkal @2opremio