Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph rendering is non-deterministic #160

Closed
paulbellamy opened this issue Jun 2, 2015 · 3 comments
Closed

Graph rendering is non-deterministic #160

paulbellamy opened this issue Jun 2, 2015 · 3 comments
Assignees

Comments

@paulbellamy
Copy link
Contributor

Makes it difficult to track/compare when changing views.

@davkal
Copy link
Contributor

davkal commented Jun 3, 2015

This might be a bigger project since we're using a third-party layout engine called Dagre. We'd have to fork and remove the random initialisers.

@davkal davkal self-assigned this Jun 15, 2015
@tomwilkie
Copy link
Contributor

[14:49] Bryan Boreham: It's fun to click around on this page, but you might want to put some thought into making it more deterministic, so when I flip from Applications to Containers and back I get the same screen each time.

@squaremo
Copy link

squaremo commented Aug 7, 2015

There's another aspect to this that may be easy to overlook. Laying the graph out consistently given a constant data set is one thing; however, some of the unpredictability comes from flipping things around when the data set changes momentarily (e.g., there has been no data over a connection for a few seconds, so it disappears).

davkal added a commit that referenced this issue Aug 22, 2015
* one render engine per topology
* improves switching back and forth between topos
* might increase memory use
* roughly fixes #160
@davkal davkal closed this as completed in 9c7dea8 Aug 24, 2015
bboreham added a commit that referenced this issue Oct 2, 2019
f041a74ff Undo some quoting that broke the test script (#160)
b1c21a068 Merge pull request #158 from weaveworks/go-1-13
d5c7dd0cd Run shell-lint during CI, and fix warnings
6db1abd14 Update to Go 1.13.1
d6cc704a2 Fix comment
7139116ae Revert "Push comments to the left so they don't appear in scripts"
e47e58f7b Push comments to the left so they don't appear in scripts
3945fcec8 Remove nonexistent env var GIT_TAG
cd6299284 Merge pull request #156 from weaveworks/drop-quay
af0eb5119 Merge pull request #157 from weaveworks/fix-image-tag-prefix-length
0b9aee4f2 Fix image-tag object name prefix length to 8 chars.
813c28fe7 Move from CircleCI 1.0 to 2.0
425cf4ef1 Move from quay.io to Dockerhub
87ccf4fd1 Merge pull request #155 from weaveworks/go-1-12
c31bc2865 Update lint script to work with Go 1.12
ed8e380d7 Update to Go 1.12.1

git-subtree-dir: tools
git-subtree-split: f041a74ffbf273b627d6c960f17357108d0dbd1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants