Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOwait plugin causes undefined status in the UI #1825

Closed
2opremio opened this issue Aug 23, 2016 · 3 comments · Fixed by #1836
Closed

IOwait plugin causes undefined status in the UI #1825

2opremio opened this issue Aug 23, 2016 · 3 comments · Fixed by #1836
Assignees
@davkal
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Milestone
1.0.0 (kubecon)

Comments

@2opremio
Copy link
Contributor

Seen in Scope 0.17.1

screen shot 2016-08-23 at 5 59 37 pm
@rade rade added the bug Broken end user or developer functionality; not working as the developers intended it label Aug 23, 2016
@rade rade modified the milestone: 0.17.2 Aug 23, 2016
@rade
Copy link
Member

rade commented Aug 23, 2016

The plugin was compiled from master. According to the user, compiling it from the v0.17.1 tag did produce a working plugin.

@rade rade changed the title IOwait plugin causes undefined status in the UI master IOwait plugin causes undefined status in the 0.17.1 UI Aug 23, 2016
@2opremio
Copy link
Contributor Author

The plugin was compiled from master. According to the user, compiling it from the v0.17.1 tag did produce a working plugin.

However, note that even compiling for 0.17.1 causes the undefined status in the UI.

@rade rade changed the title master IOwait plugin causes undefined status in the 0.17.1 UI IOwait plugin causes undefined status in the UI Aug 23, 2016
@2opremio
Copy link
Contributor Author

2opremio commented Aug 30, 2016 •
edited
Loading

I think this is a problem with the UI (or with an unpredicted format change in the /api endpoint).

Here's what I get from /api in the Scope App, which seems to be correct:

{"hostname":"vagrant-ubuntu-wily-64","id":"6f8778167e6c5ddc","plugins":[{"api_version":"1","description":"Adds a graph of CPU IO Wait to hosts","id":"iowait","interfaces":["reporter"],"label":"iowait","status":"ok"}],"version":"cffcddf"}

@2opremio 2opremio added the component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer label Aug 30, 2016
@davkal davkal self-assigned this Aug 30, 2016
davkal added a commit that referenced this issue Aug 30, 2016
@davkal
Fixes plugin renderer in status line
8ac4d0b 
The code assumed a plugin object was JS, but it's actually an immutable.
Calling `toJS` to fix.

Fixes #1825
@davkal davkal mentioned this issue Aug 30, 2016
Merged
@rade rade added this to the 0.18/1.0 milestone Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davkal davkal

Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Milestone
1.0.0 (kubecon)
Development

Successfully merging a pull request may close this issue.

Fixes plugin renderer in status line weaveworks/scope
3 participants
@rade @davkal @2opremio