-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scope-probe appears to have connection to everything #1929
Comments
@rade Where did this happen? Do you have a report? |
just look at the kube-system namespace in Weave Cloud Dev in Weave Cloud Dev. |
I found out what's happening. We are taking Pod IPs as unique when matching short-lived connections against them. This is perfectly fine for pods using their own networking namespace like the following: However, pods in the host networking namespace inherit their IP from the host. For instance: This causes Scope to attribute all the host connections to a single POD running in the host networking namespace. No regression here, this has been broken since we started tracking POD connections. The way to fix this is to check whether the pod runs in the host networking namespace to discard the short-lived connections from/to its IP. Unfortunately, this will also discard legitimate short-lived connections coming from the POD. |
Hmm. We should be able to disambiguate these connections, and "assign" them to the right pod, by taking into account the port - the IP+port combo of the source of outbound connections and the destination of inbound connections should be associated with an individual process, which in turn will give us the pod. |
We don't have PIDs for short-lived connections. So we have the exact same problem for Pods as we have for containers. In other words, we can't currently disambiguate them. ebpf should change this. |
You have a more thorough explanation in #1260 |
I wonder whether this is somehow a consequence of #1863 and associated DNS tracking PRs.
The text was updated successfully, but these errors were encountered: