Do not infer short-lived connections for host-networking containers #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var networkInfo func(prefix string) report.Sets | ||
| networkInfo = func(prefix string) report.Sets { | ||
| var networkInfo func(prefix string) (report.Sets, bool) | ||
| networkInfo = func(prefix string) (ips report.Sets, isHostMapped bool) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
2 minor nits but otherwise LGTM |
2opremio
force-pushed
the
1598-no-host-short-lived-tracking
branch
from
9b419c9 to
26c6249
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1598