Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow text selection on a scrolled up terminal. #1969

Closed
foot opened this issue Nov 1, 2016 · 8 comments
Closed

Allow text selection on a scrolled up terminal. #1969

foot opened this issue Nov 1, 2016 · 8 comments
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer dogfood Important for the developer's own use of the project help-wanted An issue that would be good for non-maintainers to attempt
Milestone
Backlog

Comments

@foot
Copy link
Contributor

foot commented Nov 1, 2016

Terminals now "scroll lock", they retain their scrolled back position if new data comes in.

However, new incoming data will still clear the current text selection making it awkward to highlight and copy and paste logs.
@foot foot added component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer chore Related to fix/refinement/improvement of end user or new/existing developer functionality help-wanted An issue that would be good for non-maintainers to attempt labels Nov 1, 2016
@foot
Copy link
Contributor Author

foot commented Nov 1, 2016

This is more of an upstream issue in xterm.js for which a PR exists.

@foot
Copy link
Contributor Author

foot commented Nov 1, 2016 •
edited
Loading

This issue is left over from #1932

@rade
Copy link
Member

rade commented Jan 10, 2017

This is quite annoying.

@foot have you got a reference for the upstream PR?

@rade rade modified the milestone: Backlog Jan 11, 2017
@rade rade added the dogfood Important for the developer's own use of the project label Jan 11, 2017
@foot
Copy link
Contributor Author

foot commented Jan 11, 2017

xtermjs/xterm.js#336 which looks to be fixed in 2.1!

Will make an issue for that..

@foot foot mentioned this issue Jan 11, 2017
Closed
@rade rade modified the milestones: EOY 2016, Backlog Jan 11, 2017
@foot
Copy link
Contributor Author

foot commented Jan 16, 2017

Sorry I got my issues confused here, losing selection is still an issue for now. xtermjs/xterm.js#468

@rade rade modified the milestones: Backlog, EOY 2016 Jan 17, 2017
@rade
Copy link
Member

rade commented Nov 12, 2017

The issue in the xterm lib has been fixed. upgrade! cc @foot

@rade
Copy link
Member

rade commented Nov 12, 2017

Hmm. We did actually update to the latest xterm.js (2.9.2) in #2900. But this issue still exists, even though the upstream issue is closed :(

@rade
Copy link
Member

rade commented Nov 12, 2017

Hmm. I've just tried it again, and now it does work. Tried container shell, container logs and pod logs, in both FF and Chrome, both locally and in Weave Cloud.

@rade rade closed this as completed Nov 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer dogfood Important for the developer's own use of the project help-wanted An issue that would be good for non-maintainers to attempt
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@foot @rade