Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade xterm.js to 2.2.3 #2121

Closed
foot opened this issue Jan 11, 2017 · 3 comments
Closed

Upgrade xterm.js to 2.2.3 #2121

foot opened this issue Jan 11, 2017 · 3 comments
Assignees
@jpellizzari
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/build An issue concerning compilation, testing, packaging, distribution component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Milestone
EOY 2016

Comments

@foot
Copy link
Contributor

foot commented Jan 11, 2017 •
edited
Loading

Should fix some more terminal niggles like #1969 - not fixed by upgrading to 2.2.3 yet.

Nice to stay up to date though.
@foot foot added the chore Related to fix/refinement/improvement of end user or new/existing developer functionality label Jan 11, 2017
@rade rade added this to the EOY 2016 milestone Jan 11, 2017
@rade rade added component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer component/build An issue concerning compilation, testing, packaging, distribution labels Jan 11, 2017
@jpellizzari
Copy link
Contributor

@foot Looks like master is already on 2.1:
https://github.com/weaveworks/scope/blob/master/client/package.json#L42

There are some new improvements in the most recent 2.2.3 release:
https://github.com/sourcelair/xterm.js/pull/379/files

@jpellizzari jpellizzari changed the title Upgrade xterm.js to 2.1 Upgrade xterm.js to 2.2.3 Jan 12, 2017
@jpellizzari jpellizzari self-assigned this Jan 12, 2017
@jpellizzari jpellizzari mentioned this issue Jan 12, 2017
Merged
@rade
Copy link
Member

rade commented Jan 13, 2017

Looks like master is already on 2.1

So why am I still seeing #1969?

@jpellizzari
Copy link
Contributor

Closed by #2126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpellizzari jpellizzari

Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/build An issue concerning compilation, testing, packaging, distribution component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Milestone
EOY 2016
Development

No branches or pull requests
4 participants
@foot @rade @2opremio @jpellizzari