Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move away from React.PropTypes #2496

Closed
fbarl opened this issue May 3, 2017 · 0 comments · Fixed by #2498
Closed

Move away from React.PropTypes #2496

fbarl opened this issue May 3, 2017 · 0 comments · Fixed by #2498
Assignees
@fbarl
Labels
component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer tech-debt Unpleasantness that does (or may in future) affect development

Comments

@fbarl
Copy link
Contributor

fbarl commented May 3, 2017

After #2487 and #2292 have been merged, we should replace React.PropTypes with https://github.com/reactjs/prop-types since the former have been deprecated in React 15.5.

See https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html#migrating-from-react.proptypes
@fbarl fbarl added component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer tech-debt Unpleasantness that does (or may in future) affect development labels May 3, 2017
@fbarl fbarl self-assigned this May 3, 2017
This was referenced May 3, 2017
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbarl fbarl

Labels
component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer tech-debt Unpleasantness that does (or may in future) affect development
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use prop-types library to silence PropTypes deprecation warning weaveworks/scope
1 participant
@fbarl