Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to prop-types library #27

Merged
merged 1 commit into from
May 4, 2017
Merged

Switch to prop-types library #27

merged 1 commit into from
May 4, 2017

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented May 4, 2017

Since this repo is now used by Scope, we also have to transition to prop-types library here to get rid of deprecation errors in Scope: weaveworks/scope#2496

@fbarl fbarl self-assigned this May 4, 2017
@fbarl fbarl requested a review from jpellizzari May 4, 2017 13:09
@fbarl fbarl changed the title [WIP] Switch to prop-types library Switch to prop-types library May 4, 2017
@fbarl fbarl mentioned this pull request May 4, 2017
Merged
jpellizzari
jpellizzari approved these changes May 4, 2017
View reviewed changes
Copy link
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbarl fbarl merged commit 0d3d921 into master May 4, 2017
@jpellizzari jpellizzari deleted the fix-prop-types branch May 17, 2017 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpellizzari jpellizzari jpellizzari approved these changes

Assignees

@fbarl fbarl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbarl @jpellizzari